-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise exception on not-implemented @setting(setter) #1591
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 156 156
Lines 15256 15257 +1
Branches 3283 3283
=======================================
+ Hits 12340 12341 +1
Misses 2667 2667
Partials 249 249
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Teemu R. <[email protected]>
@rytilahti ready to be merged. |
Can be merged after the linting issue is fixed. |
@rytilahti I think the linting issue is resolved. I am calling it a day, will continue tommorow. |
Hehe, my pleasure, have a good one! Looks like we were quite productive with short feedback cycles :-) The CI flakiness is something that has happened before and I thought using the codecov token would help, but this time you were also encountering this issues: #1580 - the tests will suddenly start working in 30 mins... |
Split out from #1586
warn for setter input from setting decorator, since it will not work to put in a function directly in the decorator since the class object has not yet been created. Therefore always the setter_name schould be used and the binding of the setter methods schould take place when the class object gets created.