Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action/run): support single file in sourceDir #409

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

yzs981130
Copy link
Contributor

I added checks before parsing the file lists as directory and return the file if dir is a file.

Also fix the fileName retrieval. Please check.

Now, the source-dir could refer to a single file.

Closes #406

@yzs981130 yzs981130 requested a review from ryand56 as a code owner March 20, 2024 09:23
@ryand56 ryand56 changed the base branch from master to develop March 23, 2024 02:46
Copy link
Owner

@ryand56 ryand56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a bug with this on my end, it adds the full path after the shortened path.
Code_IyEAS6w8x2

@yzs981130
Copy link
Contributor Author

There seems to be a bug with this on my end, it adds the full path after the shortened path. Code_IyEAS6w8x2

Could you reproduce it on non-Windows platforms?

I am unfamiliar with JavaScript and it seems that the path.basename may behave differently on Windows and non-Windows platforms (see here).

@ryand56
Copy link
Owner

ryand56 commented Mar 24, 2024

There seems to be a bug with this on my end, it adds the full path after the shortened path. Code_IyEAS6w8x2

Could you reproduce it on non-Windows platforms?

I am unfamiliar with JavaScript and it seems that the path.basename may behave differently on Windows and non-Windows platforms (see here).

Ah okay, I tested it on Windows. I'll test it on a Linux system.

@ryand56 ryand56 added this to the v1.3 milestone Mar 28, 2024
@ryand56 ryand56 merged commit b761360 into ryand56:develop Jun 10, 2024
1 check passed
ryand56 added a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Is there any way to upload specify file name, not dir
2 participants