Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't worry about an explicit run ID when --local is specified #109

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

TAGraves
Copy link
Member

Right now if you provide a run ID and specify --local, you'll get an error asking if you meant to use an ephemeral queue or not. Since you specified --local we can be confident that you did mean to use an ephemeral queue.

@TAGraves TAGraves self-assigned this Nov 20, 2024
Copy link

Bigtest for f68be01 (run)

Benchmarks:

  • RSpec: 7.64% overhead
    • RSpec time: 17.67 seconds
    • ABQ time: 19.02 seconds
  • RSpec parallel, 10 runs: max 12.51% overhead
    • min 6.17% overhead
    • standard deviation: 2.51%
  • Jest: 4.28% overhead
    • Jest time: 19.778 seconds
    • ABQ time: 20.624 seconds

Fuzz result sizes:

  • PASSED

@TAGraves TAGraves merged commit 09cbfb7 into main Nov 21, 2024
17 checks passed
@TAGraves TAGraves deleted the tg-dont-worry-about-explicit-run-id-for-local branch November 21, 2024 00:18
Copy link

Bigtest for 09cbfb7 (run)

Benchmarks:

  • RSpec: 7.37% overhead
    • RSpec time: 17.65 seconds
    • ABQ time: 18.95 seconds
  • RSpec parallel, 10 runs: max 11.84% overhead
    • min 5.72% overhead
    • standard deviation: 2.19%
  • Jest: 4.32% overhead
    • Jest time: 19.712 seconds
    • ABQ time: 20.563 seconds

Fuzz result sizes:

  • PASSED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants