Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix f5 in chrome #87

Merged
merged 4 commits into from
Apr 3, 2024
Merged

fix f5 in chrome #87

merged 4 commits into from
Apr 3, 2024

Conversation

simonLeary42
Copy link
Contributor

firefox handles f5 properly out of the box, didn't check other browsers

firefox handles f5 properly out of the box, didn't check other browsers
@simonLeary42
Copy link
Contributor Author

the diff only applies to jsonnet/windows_shortcuts.jsonnet, but CI says that json/windows_shortcuts.json was changed. Not sure what to do

@rux616
Copy link
Owner

rux616 commented Apr 1, 2024

It's detecting a difference between the JSON file on your branch and the one on the main branch. You should be able to fix it by just resyncing the branches to make sure you've got the latest changes from main.

Copy link

github-actions bot commented Apr 3, 2024

Summary of JSON file changes this PR will cause:

 json/windows_shortcuts.json | 72 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

Detailed diffs:

json/windows_shortcuts.json
diff --git a/json/windows_shortcuts.json b/json/windows_shortcuts.json
index 79646c9..ec5462b 100644
--- a/json/windows_shortcuts.json
+++ b/json/windows_shortcuts.json
@@ -1353,6 +1353,46 @@
             }
          ]
       },
+      {
+         "description": "H (Ctrl) [Only Web Browsers]",
+         "manipulators": [
+            {
+               "conditions": [
+                  {
+                     "bundle_identifiers": [
+                        "^com\\.google\\.chrome$",
+                        "^com\\.google\\.Chrome$",
+                        "^org\\.mozilla\\.firefox$",
+                        "^org\\.mozilla\\.nightly$",
+                        "^com\\.brave\\.Browser$",
+                        "^com\\.apple\\.Safari$"
+                     ],
+                     "type": "frontmost_application_if"
+                  }
+               ],
+               "from": {
+                  "key_code": "h",
+                  "modifiers": {
+                     "mandatory": [
+                        "control"
+                     ],
+                     "optional": [
+                        "any"
+                     ]
+                  }
+               },
+               "to": [
+                  {
+                     "key_code": "y",
+                     "modifiers": [
+                        "command"
+                     ]
+                  }
+               ],
+               "type": "basic"
+            }
+         ]
+      },
       {
          "description": "I (Ctrl)",
          "manipulators": [
@@ -2931,6 +2971,38 @@
                "type": "basic"
             }
          ]
+      },
+      {
+         "description": "F5 [Only Chrome]",
+         "manipulators": [
+            {
+               "conditions": [
+                  {
+                     "bundle_identifiers": [
+                        "^com\\.google\\.Chrome$"
+                     ],
+                     "type": "frontmost_application_if"
+                  }
+               ],
+               "from": {
+                  "key_code": "f5",
+                  "modifiers": {
+                     "optional": [
+                        "any"
+                     ]
+                  }
+               },
+               "to": [
+                  {
+                     "key_code": "r",
+                     "modifiers": [
+                        "command"
+                     ]
+                  }
+               ],
+               "type": "basic"
+            }
+         ]
       }
    ],
    "title": "Windows Shortcuts"

@rux616 rux616 merged commit e6acea1 into rux616:main Apr 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants