-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix f5 in chrome #87
fix f5 in chrome #87
Conversation
firefox handles f5 properly out of the box, didn't check other browsers
the diff only applies to jsonnet/windows_shortcuts.jsonnet, but CI says that json/windows_shortcuts.json was changed. Not sure what to do |
It's detecting a difference between the JSON file on your branch and the one on the |
Summary of JSON file changes this PR will cause:
Detailed diffs: json/windows_shortcuts.jsondiff --git a/json/windows_shortcuts.json b/json/windows_shortcuts.json
index 79646c9..ec5462b 100644
--- a/json/windows_shortcuts.json
+++ b/json/windows_shortcuts.json
@@ -1353,6 +1353,46 @@
}
]
},
+ {
+ "description": "H (Ctrl) [Only Web Browsers]",
+ "manipulators": [
+ {
+ "conditions": [
+ {
+ "bundle_identifiers": [
+ "^com\\.google\\.chrome$",
+ "^com\\.google\\.Chrome$",
+ "^org\\.mozilla\\.firefox$",
+ "^org\\.mozilla\\.nightly$",
+ "^com\\.brave\\.Browser$",
+ "^com\\.apple\\.Safari$"
+ ],
+ "type": "frontmost_application_if"
+ }
+ ],
+ "from": {
+ "key_code": "h",
+ "modifiers": {
+ "mandatory": [
+ "control"
+ ],
+ "optional": [
+ "any"
+ ]
+ }
+ },
+ "to": [
+ {
+ "key_code": "y",
+ "modifiers": [
+ "command"
+ ]
+ }
+ ],
+ "type": "basic"
+ }
+ ]
+ },
{
"description": "I (Ctrl)",
"manipulators": [
@@ -2931,6 +2971,38 @@
"type": "basic"
}
]
+ },
+ {
+ "description": "F5 [Only Chrome]",
+ "manipulators": [
+ {
+ "conditions": [
+ {
+ "bundle_identifiers": [
+ "^com\\.google\\.Chrome$"
+ ],
+ "type": "frontmost_application_if"
+ }
+ ],
+ "from": {
+ "key_code": "f5",
+ "modifiers": {
+ "optional": [
+ "any"
+ ]
+ }
+ },
+ "to": [
+ {
+ "key_code": "r",
+ "modifiers": [
+ "command"
+ ]
+ }
+ ],
+ "type": "basic"
+ }
+ ]
}
],
"title": "Windows Shortcuts" |
firefox handles f5 properly out of the box, didn't check other browsers