Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write out unknown tags for MediaPlaylist too #59

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Write out unknown tags for MediaPlaylist too #59

wants to merge 2 commits into from

Conversation

sdroege
Copy link
Collaborator

@sdroege sdroege commented Oct 28, 2022

Fixes #55

@sdroege
Fix clippy warning
f9b5420 
warning: useless conversion to the same type: `std::string::String`
   --> src/playlist.rs:415:77
    |
415 |             QuotedOrUnquoted::Unquoted(s) => Ok(ClosedCaptionGroupId::Other(String::from(s))),
    |                                                                             ^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `s`
    |
    = note: `#[warn(clippy::useless_conversion)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
@sdroege
Write out unknown tags for MediaPlaylist too
f66356b 
Fixes rutgersc#55
@sdroege sdroege requested a review from rutgersc October 28, 2022 08:19
@sdroege sdroege mentioned this pull request Oct 28, 2022
Open
@sdroege sdroege marked this pull request as draft October 28, 2022 08:43
@vagetman
Copy link
Contributor

So... what's left here todo, @sdroege ?

@sdroege
Copy link
Collaborator Author

sdroege commented Feb 10, 2023

So... what's left here todo, @sdroege ?

Figuring out a reliable way to distinguish where playlist and where segment tags start, and then put the unknown tags in either of the two places.

Feel free to also take this over if you have time :)

@sdroege sdroege mentioned this pull request Jan 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rutgersc rutgersc rutgersc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strange behaviour between media playlist and its segments unknown tags
3 participants
@sdroege @vagetman @rutgersc