Skip to content

Commit

Permalink
Add advisory for candid library decoding DoS vulnerability
Browse files Browse the repository at this point in the history
  • Loading branch information
rsundar01 committed Dec 8, 2023
1 parent 43af5fe commit 74ce98a
Showing 1 changed file with 41 additions and 0 deletions.
41 changes: 41 additions & 0 deletions crates/candid/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "candid"
date = "2023-12-08"
url = "https://github.com/dfinity/candid/pull/478"
categories = ["denial-of-service"]
keywords = ["candid", "canister", "icp"]
aliases = ["CVE-2023-6245", "GHSA-7787-p7x6-fq3j"]
cvss = "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H"

[versions]
patched = [ ">= 0.9.10"]
unaffected = ["< 0.9.0"]

[affected]
functions = { "candid::Decode!" = [">= 0.9.0, < 0.9.10"] }
```

# Infinite decoding loop through specially crafted payload

The Candid library causes a Denial of Service while parsing a specially crafted payload with `empty` data type. For example, if the payload is `record { * ; empty }` and the canister interface expects `record { * }` then the rust candid decoder treats `empty` as an extra field required by the type. The problem with type `empty` is that the candid rust library wrongly categorizes `empty` as a recoverable error when skipping the field and thus causing an infinite decoding loop.

Canisters using affected versions of candid are exposed to denial of service by causing the decoding to run indefinitely until the canister traps due to reaching maximum instruction limit per execution round. Repeated exposure to the payload will result in degraded performance of the canister.

For asset canister users, `dfx` versions `>= 0.14.4` to `<= 0.15.2-beta.0` ships asset canister with an affected version of candid.

### Unaffected
- Rust canisters using candid `< 0.9.0` or `>= 0.9.10`
- Rust canister interfaces of type other than `record { * }`
- Motoko based canisters
- dfx (for asset canister) `<= 0.14.3` or `>= 0.15.2`

### References
- [GitHub Security Advisory (GHSA-7787-p7x6-fq3j)](https://github.com/dfinity/candid/security/advisories/GHSA-7787-p7x6-fq3j)
- [dfinity/candid/pull/478](https://github.com/dfinity/candid/pull/478)
- [Candid Library Reference](https://internetcomputer.org/docs/current/references/candid-ref)
- [Candid Specification](https://github.com/dfinity/candid/blob/master/spec/Candid.md)
- [Internet Computer Specification](https://internetcomputer.org/docs/current/references/ic-interface-spec)


0 comments on commit 74ce98a

Please sign in to comment.