feat: thread unsafe

rustq · Nov 4, 2024 · 2cb1cee · 2cb1cee
1 parent 92dc358
commit 2cb1cee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/Threading.yml b/.github/workflows/Threading.yml
@@ -24,7 +24,7 @@ jobs:
       run: |
         cargo build --features="repl" --release
 
-    - name: Thread Safe
+    - name: Thread Safe (still unsafe)
       run: |
         ./target/release/3body -c '
           给 cx 以 程心();

diff --git a/interpreter/src/evaluator/builtins.rs b/interpreter/src/evaluator/builtins.rs
@@ -369,7 +369,7 @@ fn three_body_threading(_: Vec<Object>) -> Object {
                                 Object::Function(params, stmts, env ) => {
                                     let mut ev = Evaluator {
                                         env: {
-                                            let mut scoped_env = Env::new_with_outer(Rc::clone(&env));
+                                            let mut scoped_env = Env::new_with_outer(Rc::clone(&env)); // still thread unsafe
                                              let list = params.iter().zip({
                                                 match &args[1] {
                                                     Object::Array(arr) => arr,