Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(webpki-roots): simplify usage example #82

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

robjtede
Copy link
Contributor

copy-pasting the main usage example produces a clippy warning suggesting this instead

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening a PR 👍

@cpu
Copy link
Member

cpu commented Sep 27, 2024

CI failure is unrelated. Looks like there was an upstream data update between yesterday's cron run and this branch's run. We'll fix that separately.

@cpu
Copy link
Member

cpu commented Sep 27, 2024

CI failure is unrelated.

Ah, my mistake. It is related since the example is sourced from the template in the tooling it needs to be updated as well. @robjtede Can you update this place as well:

//! ```rust
//! let root_store = rustls::RootCertStore {
//! roots: webpki_roots::TLS_SERVER_ROOTS.iter().cloned().collect(),
//! };

@ctz ctz merged commit 7fcdd6d into rustls:main Sep 27, 2024
1 check passed
@ctz
Copy link
Member

ctz commented Sep 27, 2024

Thanks!

@robjtede robjtede deleted the patch-1 branch September 27, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants