Fix compilation issues of OpenSSL tests on 32-bit architectures #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
reviewed
Sep 19, 2024
|
It seems like clippy needs to be told somehow that this conversion is, indeed, not useless when considering different architectures? Should I add something like |
Yup, that seems fine. |
Trivial fix in test-only code, seems fair to merge without blocking for further reviews. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered this as a build failure on i686 when packaging this crate for Fedora Linux.
It looks like
openssl::asn1::Asn1Time::from_unixtakes a 64-bit number on 64-bit platforms only, and a 32-bit number on 32-bit platforms.This PR adds the suggestion that's made by rustc - add
.try_into().unwrap()to explicitly convert to an u32 (and fail if the number is out of range).