feat: Migrate from ktls-recvmsg to nix 0.28

Cargo.toml

@@ -22,9 +22,9 @@ memoffset = "0.9.0"
 pin-project-lite = "0.2.13"
 tokio = { version = "1.36.0", features = ["net", "macros", "io-util"] }
 ktls-sys = "1.0.1"
-ktls-recvmsg = { version = "0.1.3" }
 num_enum = "0.7.2"
 futures-util = "0.3.30"
+nix = { version = "0.28.0", features = ["socket", "uio", "net"] }
 
 [dev-dependencies]
 lazy_static = "1.4.0"

src/ktls_stream.rs

@@ -1,4 +1,7 @@
-use ktls_recvmsg::{recvmsg, ControlMessageOwned, Errno, MsgFlags, SockaddrIn};
+use nix::{
+    errno::Errno,
+    sys::socket::{recvmsg, ControlMessageOwned, MsgFlags, SockaddrIn, TlsGetRecordType},
+};
 use num_enum::FromPrimitive;
 use std::{
     io::{self, IoSliceMut},
@@ -71,17 +74,6 @@ enum TlsAlertDescription {
     Other(u8),
 }
 
-#[derive(Debug, PartialEq, Clone, Copy, num_enum::FromPrimitive)]
-#[repr(u8)]
-enum TlsRecordType {
-    ChangeCipherSpec = 20,
-    Alert = 21,
-    Handshake = 22,
-    ApplicationData = 23,
-    #[num_enum(catch_all)]
-    Other(u8),
-}
-
 impl<IO> AsyncRead for KtlsStream<IO>
 where
     IO: AsRawFd + AsyncRead + AsyncReadReady,
@@ -165,11 +157,11 @@ where
                     _ => panic!("unexpected cmsg type: {cmsg:#?}"),
                 };
 
-                match TlsRecordType::from_primitive(record_type) {
-                    TlsRecordType::ChangeCipherSpec => {
+                match record_type {
+                    TlsGetRecordType::ChangeCipherSpec => {
                         panic!("change_cipher_spec isn't supported by the ktls crate")
                     }
-                    TlsRecordType::Alert => {
+                    TlsGetRecordType::Alert => {
                         // the alert level and description are in iovs
                         let iov = r.iovs().next().expect("expected data in iovs");
 
@@ -229,21 +221,24 @@ where
                         }
                         return task::Poll::Ready(Ok(()));
                     }
-                    TlsRecordType::Handshake => {
+                    TlsGetRecordType::Handshake => {
                         // TODO: this is where we receive TLS 1.3 resumption tickets,
                         // should those be stored anywhere? I'm not even sure what
                         // format they have at this point
                         tracing::trace!(
                             "ignoring handshake message (probably a resumption ticket)"
                         );
                     }
-                    TlsRecordType::ApplicationData => {
+                    TlsGetRecordType::ApplicationData => {
                         unreachable!("received TLS application in recvmsg, this is supposed to happen in the poll_read codepath")
                     }
-                    TlsRecordType::Other(t) => {
+                    TlsGetRecordType::Unknown(t) => {
                         // just ignore the record?
                         tracing::trace!("received record_type {t:#?}");
                     }
+                    _ => {
+                        tracing::trace!("received unsupported record type");
+                    }
                 };
 
                 // FIXME: this is hacky, but can we do better?