Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade time to 0.3.35 #168

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

DefiCake
Copy link
Contributor

@DefiCake DefiCake commented Nov 7, 2024

Fixes the following issue with future rust compiler:

  --> /Users/mad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.28/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on crate `time` caused by an API change in Rust 1.80.0; update `time` to version `>=0.3.35` by calling `cargo update`

@chifflier chifflier self-assigned this Jan 21, 2025
@chifflier
Copy link
Member

Hi,
Sorry for the delay. The matrix tests in CI include builds with rustc 1.84 and nightly, and raise no error.
Is this still required? In the meantime, I'm closing the issue (no error here), do not hesitate to reopen if needed.
Thanks

@chifflier chifflier closed this Jan 21, 2025
@chifflier
Copy link
Member

Doh, after a test (cargo update -p time --precise 0.3.30 followed by cargo build) I had the same error. Reopening

@chifflier chifflier reopened this Jan 21, 2025
@chifflier chifflier linked an issue Jan 21, 2025 that may be closed by this pull request
@chifflier
Copy link
Member

Note: this will cause a bump in MSRV (probably to 1.67), to be fixed in another commit

@chifflier chifflier merged commit c2825d0 into rusticata:master Jan 21, 2025
11 of 13 checks passed
@chifflier
Copy link
Member

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot compile x509-parser from rust toolchain >= 1.80.0
2 participants