Remove test-runner crate #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-h-chamberlain
requested review from
a team,
AzureMarker,
FenrirWolf and
Meziu
Since we don't have a local crate to test anymore, just use remote checkout of ctru-rs instead.
ian-h-chamberlain
force-pushed
the
feat/remove-test-runner-crate
branch
from
25f7d0e to
15d28c7
Compare
Meziu
approved these changes
Apr 20, 2024
Meziu
previously approved these changes
Apr 21, 2024
ian-h-chamberlain
force-pushed
the
feat/remove-test-runner-crate
branch
from
fab1313 to
d8e594b
Compare
The devkitarm container doesn't have `gh` so we just make a raw API query, and because the repo is public we don't need a token.
ian-h-chamberlain
force-pushed
the
feat/remove-test-runner-crate
branch
from
8385c3b to
59851fd
Compare
|
Issues with commit SHA? It seems like the CI is still failing because it's unable to find the crate at this repo, and also because there are some issues with finding the output files (?). Is this expected? |
2 tasks
@Meziu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5 — although we may still want to rename this repo to something simpler like
actionsinstead of referencing the no-longer presenttest-runnercrate.