Skip to content

Commit

Permalink
Add valgrind suppressions for GrClearImage
Browse files Browse the repository at this point in the history
Similar to existing supprresions for bogus errors in GrConvertPixels.

Change-Id: I50f3b47ca3a88c71af532fa69aa2566ad0f03753
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/252802
Commit-Queue: Brian Salomon <[email protected]>
Commit-Queue: Robert Phillips <[email protected]>
Auto-Submit: Brian Salomon <[email protected]>
Reviewed-by: Robert Phillips <[email protected]>
  • Loading branch information
bsalomon committed Nov 5, 2019
1 parent 6af9b1c commit e9b5469
Showing 1 changed file with 19 additions and 3 deletions.
22 changes: 19 additions & 3 deletions tools/valgrind.supp
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,9 @@
fun:_ZN12_GLOBAL__N_120ConvolveHorizontallyILb0EEEvPKhRK21SkConvolutionFilter1DPh
fun:_Z14BGRAConvolve2DPKhibRK21SkConvolutionFilter1DS3_iPhRK18SkConvolutionProcsb
}
#Something odd happening in with SkRasterPipeline in GrConvertPixels. Seems bogus after
#investigation. MSAN/ASAN have no complaints. Complaining about conditional jump or use
#of var that is "uninitialized" but it definitely is.
#Something odd is happening in SkRasterPipeline when called by GrConvertPixels and GrClearImage.
#It seems bogus after investigation. MSAN/ASAN have no complaints. It's complaining about
#conditional jump or use of var that is "uninitialized" but it definitely is.
{
grconvertpixels_rasterpipeline
Memcheck:Cond
Expand All @@ -301,3 +301,19 @@
fun:_Z15GrConvertPixelsRK11GrImageInfoPvmS1_PKvmb
...
}
{
grclearimage_rasterpipeline
Memcheck:Cond
...
fun:_ZNK16SkRasterPipeline3runEmmmm
fun:_Z12GrClearImageRK11GrImageInfoPvm8SkRGBA4fIL11SkAlphaType3EE
...
}
{
grclearimage_rasterpipeline
Memcheck:Value8
...
fun:_ZNK16SkRasterPipeline3runEmmmm
fun:_Z12GrClearImageRK11GrImageInfoPvm8SkRGBA4fIL11SkAlphaType3EE
...
}

0 comments on commit e9b5469

Please sign in to comment.