Skip to content

Commit

Permalink
run clang-tidy on headers too
Browse files Browse the repository at this point in the history
Without -header-filter='.*' clang-tidy only checks the .cpp file.

Change-Id: Ib49081faa2ddf20222dfeb15841cf2b812c22462
Reviewed-on: https://skia-review.googlesource.com/c/176967
Commit-Queue: Mike Klein <[email protected]>
Auto-Submit: Mike Klein <[email protected]>
Reviewed-by: Brian Salomon <[email protected]>
  • Loading branch information
Mike Klein authored and Skia Commit-Bot committed Dec 12, 2018
1 parent e855b9d commit ad64873
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/gpu/ops/GrSimpleMeshDrawOpHelper.h
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,9 @@ std::unique_ptr<GrDrawOp> GrSimpleMeshDrawOpHelper::FactoryHelper(GrContext* con
} else {
char* mem = (char*) pool->allocate(sizeof(Op) + sizeof(GrProcessorSet));
char* setMem = mem + sizeof(Op);
auto color = paint.getColor4f();
makeArgs.fProcessorSet = new (setMem) GrProcessorSet(std::move(paint));

return std::unique_ptr<GrDrawOp>(new (mem) Op(makeArgs, paint.getColor4f(),
return std::unique_ptr<GrDrawOp>(new (mem) Op(makeArgs, color,
std::forward<OpArgs>(opArgs)...));
}
}
Expand Down
2 changes: 1 addition & 1 deletion tools/clang-tidy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ while [ "$1" ]; do
done

if [ "$src" ]; then
clang-tidy -quiet -warnings-as-errors='*' $src -- $args
clang-tidy -quiet -header-filter='.*' -warnings-as-errors='*' $src -- $args
fi
exec clang++ $args

0 comments on commit ad64873

Please sign in to comment.