Fix CI #103
Merged
Fix CI #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
reviewed
Sep 26, 2024
.github/workflows/test.yml
Outdated
| @@ -130,7 +131,8 @@ jobs: | |||
| - aarch64-linux-android | |||
| - arm-linux-androideabi | |||
| - armv7-linux-androideabi | |||
| - x86_64-linux-android | |||
| # TODO: error: cannot find -lunwind | |||
| # - x86_64-linux-android | |||
There was a problem hiding this comment.
I'm not particularly keen on disabling the android target. It isn't some obscure target like the mips ones. It would be better to just fix it. Failing that, I would prefer to keep a reminder that this is broken.
There was a problem hiding this comment.
I am not sure that x86_64-linux-android isn't some obscure target like the mips.
Now we can build aarch64-linux-android. Anyway, I need to look deeper into this issue.
| default: true | ||
| - name: Install cross | ||
| run: | | ||
| cargo install cross --git https://github.com/cross-rs/cross |
There was a problem hiding this comment.
Why --git? I guess they haven't produced any releases recently, is that why?
There was a problem hiding this comment.
I've read it from README.
Anyway, I can remove it, if it needs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102