Fix match enum OR comment indentation #6086
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6060
This was a bit tricky.
When the inner item is multiline, identation-count before the actual inner item start throws off the line count.
In the usual case, the inner item doesn't contain indentation, example:
in the above case, the inner item is
i: i32
, no comma, no indentation.So when calculating whether the inner item is too long to add more spaces already, indentation needs to be
removed beforehand, but only for inner items that have newlines in them. In the below case, the inner item is the entire:
Newlines and indentation all.
If the line does become too long by the comment, it will be split and use the old logic in a branch, I added a test for that as well.