Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue 4573 #5325

Merged
merged 1 commit into from
May 8, 2022
Merged

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Apr 29, 2022

It's unclear which PR resolved this issue, however the behavior of adding inline comments to the next line can't be reproduced.

These test cases should serve to prevent a regression.

Closes #4573

@calebcartwright
Copy link
Member

Would you add some cases that have multiple attributes with comments in different/multiple positions as well?

It's unclear which PR resolved this issue, however the behavior of
adding inline comments to the next line can't be reproduced.

These test cases should serve to prevent a regression.
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@calebcartwright calebcartwright merged commit 3cc1f5e into rust-lang:master May 8, 2022
@ytmimi ytmimi deleted the issue_4573 branch August 7, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt makes it impossible to explain attributes with comments in the same line
2 participants