Skip to content

Commit

Permalink
Simplify some lifetimes
Browse files Browse the repository at this point in the history
  • Loading branch information
camsteffen committed Feb 8, 2024
1 parent 61a764f commit 2640a40
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions src/modules.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,16 @@ pub(crate) enum ModuleResolutionErrorKind {
}

#[derive(Clone)]
enum SubModKind<'a, 'ast> {
enum SubModKind<'a> {
/// `mod foo;`
External(PathBuf, DirectoryOwnership, Module<'ast>),
External(PathBuf, DirectoryOwnership, Module<'static>),
/// `mod foo;` with multiple sources.
MultiExternal(Vec<(PathBuf, DirectoryOwnership, Module<'ast>)>),
MultiExternal(Vec<(PathBuf, DirectoryOwnership, Module<'static>)>),
/// `mod foo {}`
Internal(&'a ast::Item),
}

impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {
impl<'ast, 'sess> ModResolver<'ast, 'sess> {
/// Creates a new `ModResolver`.
pub(crate) fn new(
parse_sess: &'sess ParseSess,
Expand Down Expand Up @@ -179,7 +179,7 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {

fn visit_sub_mod(
&mut self,
item: &'c ast::Item,
item: &ast::Item,
sub_mod: Module<'_>,
) -> Result<(), ModuleResolutionError> {
let sub_mod_kind = self.peek_sub_mod(item, &sub_mod)?;
Expand All @@ -191,11 +191,11 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {
}

/// Inspect the given sub-module which we are about to visit and returns its kind.
fn peek_sub_mod(
fn peek_sub_mod<'a>(
&self,
item: &'c ast::Item,
item: &'a ast::Item,
sub_mod: &Module<'_>,
) -> Result<Option<SubModKind<'c, 'ast>>, ModuleResolutionError> {
) -> Result<Option<SubModKind<'a>>, ModuleResolutionError> {
if contains_skip(&item.attrs) {
return Ok(None);
}
Expand All @@ -212,7 +212,7 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {

fn insert_sub_mod(
&mut self,
sub_mod_kind: SubModKind<'c, 'ast>,
sub_mod_kind: SubModKind<'_>,
) -> Result<(), ModuleResolutionError> {
match sub_mod_kind {
SubModKind::External(mod_path, _, sub_mod) => {
Expand All @@ -235,7 +235,7 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {
fn visit_sub_mod_inner(
&mut self,
sub_mod: Module<'_>,
sub_mod_kind: SubModKind<'c, 'ast>,
sub_mod_kind: SubModKind<'_>,
) -> Result<(), ModuleResolutionError> {
match sub_mod_kind {
SubModKind::External(mod_path, directory_ownership, sub_mod) => {
Expand Down Expand Up @@ -268,7 +268,7 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {
mod_name: symbol::Ident,
attrs: &[ast::Attribute],
sub_mod: &Module<'_>,
) -> Result<Option<SubModKind<'c, 'ast>>, ModuleResolutionError> {
) -> Result<Option<SubModKind<'static>>, ModuleResolutionError> {
let relative = match self.directory.ownership {
DirectoryOwnership::Owned { relative } => relative,
DirectoryOwnership::UnownedViaBlock => None,
Expand Down Expand Up @@ -433,7 +433,7 @@ impl<'ast, 'sess, 'c> ModResolver<'ast, 'sess> {
&self,
attrs: &[ast::Attribute],
sub_mod: &Module<'_>,
) -> Vec<(PathBuf, DirectoryOwnership, Module<'ast>)> {
) -> Vec<(PathBuf, DirectoryOwnership, Module<'static>)> {
// Filter nested path, like `#[cfg_attr(feature = "foo", path = "bar.rs")]`.
let mut path_visitor = visitor::PathVisitor::default();
for attr in attrs.iter() {
Expand Down

0 comments on commit 2640a40

Please sign in to comment.