-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dest prop on mir-opt-level=2 #82904
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2dab3be69f0ad7c1ca9897642480ea1c81b9949f with merge 78261356a28cc4cbbdc805422e42a2c71719ae95... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
☔ The latest upstream changes (presumably #82896) made this pull request unmergeable. Please resolve the merge conflicts. |
2dab3be
to
d4a2c48
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit d4a2c48 with merge 280adcdab341682f9f3323ccf1d30db4eef20844... |
☀️ Try build successful - checks-actions |
Queued 280adcdab341682f9f3323ccf1d30db4eef20844 with parent 8f349be, future comparison URL. |
Finished benchmarking try commit (280adcdab341682f9f3323ccf1d30db4eef20844): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
The parent commit 8f349be is not benchmarked, nor is it queued to be benchmarked. |
Here's the diff to another parent commit: https://perf.rust-lang.org/compare.html?start=1d6b0f626aad4ee9f2eaec4d5582f45620ccab80&end=280adcdab341682f9f3323ccf1d30db4eef20844&stat=instructions%3Au Hopefully representative and doesn't include changes from the immediate parent. |
Looks all pretty noisy. Maybe rebase and run perf again? But from the looks of it this optimization doesn't actually change anything performance wise. |
The transformation was disabled in #82684, so the second run was ineffective. |
Oh... I guess we have to fix dest prop first |
parent commit should now be queued, looks like we missed the GitHub notification. |
Let's test the performance of making this change, note that mir-opt-level is 2 by default in optimized builds.
r? @oli-obk