Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dest prop on mir-opt-level=2 #82904

Closed

Conversation

spastorino
Copy link
Member

Let's test the performance of making this change, note that mir-opt-level is 2 by default in optimized builds.

r? @oli-obk

@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 8, 2021
@bors
Copy link
Contributor

bors commented Mar 8, 2021

⌛ Trying commit 2dab3be69f0ad7c1ca9897642480ea1c81b9949f with merge 78261356a28cc4cbbdc805422e42a2c71719ae95...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Mar 8, 2021

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 8, 2021
@bors
Copy link
Contributor

bors commented Mar 8, 2021

☔ The latest upstream changes (presumably #82896) made this pull request unmergeable. Please resolve the merge conflicts.

@spastorino spastorino force-pushed the dest_prop-opt-level-2 branch from 2dab3be to d4a2c48 Compare March 8, 2021 19:50
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Mar 8, 2021

⌛ Trying commit d4a2c48 with merge 280adcdab341682f9f3323ccf1d30db4eef20844...

@bors
Copy link
Contributor

bors commented Mar 8, 2021

☀️ Try build successful - checks-actions
Build commit: 280adcdab341682f9f3323ccf1d30db4eef20844 (280adcdab341682f9f3323ccf1d30db4eef20844)

@rust-timer
Copy link
Collaborator

Queued 280adcdab341682f9f3323ccf1d30db4eef20844 with parent 8f349be, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (280adcdab341682f9f3323ccf1d30db4eef20844): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 8, 2021
@bjorn3
Copy link
Member

bjorn3 commented Mar 9, 2021

The parent commit 8f349be is not benchmarked, nor is it queued to be benchmarked.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 9, 2021

Here's the diff to another parent commit: https://perf.rust-lang.org/compare.html?start=1d6b0f626aad4ee9f2eaec4d5582f45620ccab80&end=280adcdab341682f9f3323ccf1d30db4eef20844&stat=instructions%3Au

Hopefully representative and doesn't include changes from the immediate parent.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 9, 2021

Looks all pretty noisy. Maybe rebase and run perf again? But from the looks of it this optimization doesn't actually change anything performance wise.

@tmiasko
Copy link
Contributor

tmiasko commented Mar 9, 2021

The transformation was disabled in #82684, so the second run was ineffective.

@oli-obk
Copy link
Contributor

oli-obk commented Mar 9, 2021

Oh... I guess we have to fix dest prop first

@oli-obk oli-obk closed this Mar 9, 2021
@Mark-Simulacrum
Copy link
Member

parent commit should now be queued, looks like we missed the GitHub notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants