Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENTAL] Bisect cmake bootstrap issue #134558

Closed
wants to merge 3 commits into from

Conversation

clubby789
Copy link
Contributor

r? @ghost
Investigating #134344
try-job: dist-apple-various

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 20, 2024
@clubby789
Copy link
Contributor Author

@bors try

@clubby789 clubby789 added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@bors
Copy link
Contributor

bors commented Dec 20, 2024

⌛ Trying commit e026233 with merge 61c63b9...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 20, 2024

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 20, 2024
@clubby789
Copy link
Contributor Author

0.1.50 is bad, trying 0.1.49
@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@bors
Copy link
Contributor

bors commented Dec 20, 2024

⌛ Trying commit e627f77 with merge 149f420...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 20, 2024

💔 Test failed - checks-actions

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 20, 2024
@clubby789
Copy link
Contributor Author

clubby789 commented Dec 20, 2024

1.49 is bad - checking ba6b3bc4712af4cda5513f01699b00631248f576

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@bors
Copy link
Contributor

bors commented Dec 20, 2024

⌛ Trying commit 9c484f7 with merge 46520ed...

@bors
Copy link
Contributor

bors commented Dec 20, 2024

☀️ Try build successful - checks-actions
Build commit: 46520ed (46520ed91444db5dda462f8f4e41558cfdfab1b0)

@clubby789
Copy link
Contributor Author

clubby789 commented Dec 20, 2024

ba6b3bc good, trying edc139b77

@bors try

@bors
Copy link
Contributor

bors commented Dec 20, 2024

⌛ Trying commit 2a9d4c6 with merge 34774f8...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 20, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 20, 2024

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 21, 2024

💔 Test failed - checks-actions

@jieyouxu
Copy link
Member

rust-lang/cmake-rs@d668808 bad, trying rust-lang/cmake-rs@163d33f

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@bors
Copy link
Contributor

bors commented Dec 21, 2024

⌛ Trying commit f968c86 with merge 4039363...

@bors
Copy link
Contributor

bors commented Dec 21, 2024

☀️ Try build successful - checks-actions
Build commit: 4039363 (40393637d8bbfd2175f671bcdbb76ee300bfa82b)

@clubby789
Copy link
Contributor Author

d66808 confirmed bad. Will see if I can investigate a fix

@clubby789
Copy link
Contributor Author

This should fix it - if this works and the most recent version of cmake works, let's try and land the bump
@bors try

@bors
Copy link
Contributor

bors commented Dec 21, 2024

⌛ Trying commit 1de6212 with merge f048f9e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@clubby789
Copy link
Contributor Author

Oops, need to use the 'bad' version of cc

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@bors
Copy link
Contributor

bors commented Dec 21, 2024

⌛ Trying commit fcee667 with merge 583f4f0...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 21, 2024

💔 Test failed - checks-actions

@clubby789
Copy link
Contributor Author

clubby789 commented Dec 21, 2024

Hmm. Looks like telling Cmake we're using iOS causes it to run iOS-initalize.cmake, which errors because of

// These two defines prevent CMake from automatically trying to add a MacOSX sysroot, which leads to a compiler error.
cfg.define("CMAKE_OSX_SYSROOT", "/");
cfg.define("CMAKE_OSX_DEPLOYMENT_TARGET", "");

#73903 (comment)

Let's see if this hack is unecessary now

@clubby789
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2024
[EXPERIMENTAL] Bisect cmake bootstrap issue

r? `@ghost`
Investigating rust-lang#134344
try-job: dist-apple-various
@bors
Copy link
Contributor

bors commented Dec 21, 2024

⌛ Trying commit 7a9b033 with merge 0f380ea...

@rust-log-analyzer
Copy link
Collaborator

The job dist-apple-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Updating files:  98% (49925/50943)
Updating files:  99% (50434/50943)
Updating files: 100% (50943/50943)
Updating files: 100% (50943/50943), done.
Switched to a new branch 'try'
branch 'try' set up to track 'origin/try'.
[command]/usr/local/bin/git log -1 --format=%H
0f380ea86d2f090f353e780b0171816cadd698fc
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
   Compiling clap_complete v4.5.40
   Compiling xz2 v0.1.7
   Compiling toml v0.5.11
   Compiling fd-lock v4.0.2
   Compiling cmake v0.1.48 (https://github.com/rust-lang/cmake-rs?rev=d6688089f1e96f5bb0ecdb770b83da4994c4b3ef#d6688089)
   Compiling home v0.5.11
   Compiling opener v0.5.2
   Compiling build_helper v0.1.0 (/Users/runner/work/rust/rust/src/build_helper)
   Compiling termcolor v1.4.1

@bors
Copy link
Contributor

bors commented Dec 21, 2024

💔 Test failed - checks-actions

@clubby789
Copy link
Contributor Author

Not sure why -DCMAKE_OSX_SYSROOT=/" "-DCMAKE_OSX_DEPLOYMENT_TARGET=" " is still being passed. I'll leave this for now until I have access to a Mac to iterate faster

@clubby789 clubby789 closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants