Rollup of 8 pull requests #111585
Merged
Rollup of 8 pull requests #111585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the immediate_dominator return type to Option, and use None to indicate that node has no immediate dominator. Also fix the issue where the start node would be returned as its own immediate dominator.
A warning about an unnecessary drop used to appear when running the linkchecker. Also some clippy warnings
These examples were listed twice and also were confusable with doing a substring match instead of a any-of-set match.
Update doc for `PhantomData` to match code example After rust-lang#106621, there is no longer a `T: 'a` annotation in the doc example, so update the text to match the code.
…r=compiler-errors Fix ice caused by shorthand fields in NoFieldsForFnCall Fixes rust-lang#111416
…illot Start node has no immediate dominator Change the immediate_dominator return type to Option, and use None to indicate that node has no immediate dominator. Also fix the issue where the start node would be returned as its own immediate dominator.
… r=compiler-errors add util function to TokenStream to eliminate some clones Another proposed change in the same vein as rust-lang#111492 trying to get rid of some clones. This adds a TokenStream helper function so that rustdoc can directly get a chunks iterator over the underlying token trees so that it no longer needs the clones and vec.
…r=cjgillot Simplify find_width_of_character_at_span. This makes `find_width_of_character_at_span` simpler and more robust against bad spans. Fixes (but does not close, per beta policy) rust-lang#111485
Appease lints Resolved an unnecessary drop warning that appeared when running the linkchecker. Some clippy warnings, too. Edit: Well this fired up all the CI pipeline. I hope that's not a problem.
…rkingjubilee Fix some misleading and copy-pasted `Pattern` examples These examples were listed twice and also were confusable with doing a substring match instead of a any-of-set match.
…orkingjubilee (docs) Change "wanting" to "want" Changing " If you’re wanting" to "If you want". Wanting is not wrong, of course, but I think that "If you want" feels more natural to most readers.
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 8006510ab0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 15, 2023
|
Finished benchmarking commit (2913ad6): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 641.463s -> 642.148s (0.11%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
PhantomDatato match code example #102673 (Update doc forPhantomDatato match code example)Patternexamples #111581 (Fix some misleading and copy-pastedPatternexamples)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup