Run x test tidy sooner in mingw-check

[jyn514]

It takes less time to run than the other tests and is more likely to fail. expand-yaml-anchors is still run first to make sure the CI files are internally consistent.

Note that changing to --stage 0 doesn't actually do anything since bootstrap tools are always built with the bootstrap compiler, this just makes it less confusing.

cc 83bab41

[rustbot]

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

@bors r+ rollup

[bors]

📌 Commit c99f1b7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[Noratrieb]

This didn't exactly work as expected.
Tidy only started here, with an entire x check still running before.
https://github.com/rust-lang/rust/actions/runs/3697810827/jobs/6263246796#step:26:2872

[Noratrieb]

@bors r- as discussed with Joshua

[Mark-Simulacrum]

Note that we run the script here twice, once with parallel and once without. Please check you're not looking at the second run. It should still fail fast.

[Noratrieb]

In #105058 it didn't fast-fail when I applied the same change

[jyn514]

Note that we run the script here twice, once with parallel and once without. Please check you're not looking at the second run. It should still fail fast.

amazing pointer, thank you ❤️ turns out we were running the parallel script first, which seems like the wrong thing - pushed a commit switching the order.

[Mark-Simulacrum]

@bors r+

I'm not convinced this is meaningful (i.e., the order doesn't seem like it would matter to me, especially for tidy). But 🤷

[bors]

📌 Commit fc6d59d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[matthiaskrgr]

got a weird cp: cannot stat 'obj/build/metrics.json': No such file or directory in ci for mingw-check, no idea if thats spurious or not
@bors rollup=iffy

[jyn514]

Oh, that's probably from reordering the parallel compiler build. I'll look into it.

@bors r-

[jyn514]

@bors r=Mark-Simulacrum

[bors]

📌 Commit b8a84c2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

⌛ Testing commit b8a84c2 with merge b64fc3f69ca2c43d72984847cb383da0fb0a7892...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.......... (90/93)
...        (93/93)


/checkout/src/test/rustdoc-gui/scrape-examples-button-focus.goml scrape-examples-button-focus... FAILED
[ERROR] (line 12) Error: Evaluation failed: The following errors happened (for selector `.scraped-example-list > .scraped-example pre`): [Expected `248` for property `scrollTop`, found `249`]: for command `assert-property: (".scraped-example-list > .scraped-example pre", {
 "scrollTop": |initialScrollTop|

Build completed unsuccessfully in 0:02:32

[jyn514]

@bors retry

[bors]

⌛ Testing commit b8a84c2 with merge 37efc81...

[bors]

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 37efc81 to master...

[rust-timer]

Finished benchmarking commit (37efc81): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.9%, 1.3%]	2
Regressions ❌ (secondary)	1.2%	[1.0%, 1.3%]	2
Improvements ✅ (primary)	-1.8%	[-2.1%, -1.4%]	2
Improvements ✅ (secondary)	-1.6%	[-2.2%, -1.4%]	3
All ❌✅ (primary)	-0.3%	[-2.1%, 1.3%]	4

Cycles

This benchmark run did not return any relevant results for this metric.