Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link continuing goals to their previous period goal #236

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

lqd
Copy link
Member

@lqd lqd commented Jan 22, 2025

For #228, this PR implements part of the proposal for continuing goals described here, by linking the continuing goals to their previous period goal.

I'll duplicate the proposal here for simplicity, and this PR is the first point:


Proposal:

  • we link the continuing goals to the previous period's tracking issue
  • we post a comment in each tracking issue of the continuing goals as a marker comment, prior to posting the new period's first update
  • and mention in the OP the periods to which this goal applies, and link to each marker period.
  • in addition to having all of the periods' associated github milestones, if we can have multiple milestones on github which I'm not sure; otherwise, just the most recent one is also fine: changing the milestone will also leave an update event in the github history / comments list, IIRC.

Compared to the list in that issue, I didn't mark the goals related to running the program itself, or stabilizing it, between this period and the previous one -- as that seems kind of expected and not necessarily useful compared to the actual goals themselves. I also did mark a-mir-formality as continuing even if the scope changed quite a bit.

(there's also a handful of cosmetic fixes, a help wanted link here, unifying the metadata tables and aligning it, a proposed goal was marked as accepted, trivial things like that)

Rendered

src/TEMPLATE.md Outdated
@@ -12,7 +12,7 @@
> or **Proposed, Invited** (if you do not yet).

| Metadata | |
|------------------|----------------------------------------------------------------------------------|
|:-----------------|----------------------------------------------------------------------------------|
| Point of contact | *must be a single Github username like @ghost* |
| Teams | <!-- TEAMS WITH ASKS --> |
| Task owners | <!-- TASK OWNERS --> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the following lines

| Tracking issue | *if this is a continuing goal, add the old tracking issue, else leave blank* |
| Continuing goal | *if this is a continuing goal, provide a link, else leave blank* |

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed on zulip that it'll be simpler to only do the first of these two changes, and I pushed a commit to address that.

| Task owners | <!-- TASK OWNERS --> |
| Status | Proposed |
| Zulip channel | [#t-types/polonius][channel] |
| Continuing goal | [2024h2 project goal] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for each goal that is continuing we should have a link

| Tracking issue | [rust-lang/rust-project-goals#109]   |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idea is that this way the script will not create a new issue

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

lqd added 2 commits January 23, 2025 16:48
remove dedicated link, but add previous tracking issue to all continuing
goals instead
@nikomatsakis nikomatsakis merged commit b8a3ea4 into rust-lang:main Jan 23, 2025
2 checks passed
@lqd lqd deleted the continuing-goals branch January 23, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants