Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix last clippy lints and enforce in CI #3106

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 1, 2025

  • turns out clippy was part of CI, but was not used to enforce anything
  • clippy should not use nightly channel
  • check-cfg has been stabilized since 1.80, so no need for a separate CI job
  • rustfmt is the only job requiring nightly

Also, I think we should remove installation of the stable rust - github runners have been very good at keeping rust version up to date, no need to waste time for each job to install it.

@nyurik nyurik changed the title chore: fix new clippy lints chore: fix new clippy lints and enforce in CI Feb 1, 2025
@nyurik nyurik changed the title chore: fix new clippy lints and enforce in CI chore: fix lats clippy lints and enforce in CI Feb 1, 2025
@nyurik nyurik changed the title chore: fix lats clippy lints and enforce in CI chore: fix last clippy lints and enforce in CI Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant