Change Callbacks API.
#2766
Open
Change Callbacks API.
#2766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
int-macro-i128
branch
4 times, most recently
from
de17fc8 to
aba0479
Compare
reitermarkus
commented
Feb 21, 2024
reitermarkus
force-pushed
the
int-macro-i128
branch
from
d4984df to
2443850
Compare
reitermarkus
commented
Feb 21, 2024
reitermarkus
force-pushed
the
int-macro-i128
branch
2 times, most recently
from
8b65527 to
0600260
Compare
emilio
reviewed
Feb 26, 2024
reitermarkus
force-pushed
the
int-macro-i128
branch
2 times, most recently
from
8178f51 to
ba72f63
Compare
|
@emilio, changed the code to skip non-UTF-8 items instead of crashing. |
kulp
reviewed
Feb 28, 2024
reitermarkus
force-pushed
the
int-macro-i128
branch
from
ba72f63 to
11b0789
Compare
reitermarkus
force-pushed
the
int-macro-i128
branch
from
2bac4dd to
8e200cd
Compare
|
@emilio, can you have a look here again? Thanks. |
reitermarkus
force-pushed
the
int-macro-i128
branch
from
8e200cd to
80af414
Compare
|
☔ The latest upstream changes (presumably 770abd9) made this pull request unmergeable. Please resolve the merge conflicts. |
reitermarkus
force-pushed
the
int-macro-i128
branch
from
80af414 to
e3bc2db
Compare
reitermarkus
force-pushed
the
int-macro-i128
branch
from
e3bc2db to
256ea2e
Compare
|
@emilio, please have another look here. |
|
☔ The latest upstream changes (presumably 4ec9950) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2369 for easier review.
Also apply
#[allow(unused_variables)]everywhere to show nicer argument names in docs.