Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_flat_map sink combinator #537

Merged
merged 2 commits into from
Aug 7, 2017
Merged

Conversation

exrook
Copy link
Contributor

@exrook exrook commented Jul 22, 2017

Add a with_flat_map combinator to Sink, similar to flat_map from std::Iterator

@alexcrichton
Copy link
Member

Thanks! I wonder though, would this perhaps be better to return a stream rather than an iterator?

@exrook
Copy link
Contributor Author

exrook commented Jul 24, 2017

That's probably a better idea, I only used iterator because I wasn't sure how to implement it with Stream. I'll see if I can figure it out sometime this week.

@exrook
Copy link
Contributor Author

exrook commented Aug 2, 2017

I found the time to rewrite this patch to work with Streams rather than iterators. Let me know if you have any other suggestions.

@alexcrichton
Copy link
Member

Thanks!

@alexcrichton alexcrichton merged commit 3c067a7 into rust-lang:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants