Add multiple ids[] parameters support for GET /api/v1/crates/:id/versions
#10314
+132
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or `GET /api/v1/crates/:id/versions`
…es/:id/versions`
|
We could also consider allowing |
LawnGnome
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
The functionality LGTM. 👍
We could also consider allowing
ids[]to acceptidorsemverstring (num).
I think I'd prefer to keep those separate — while it's theoretically possible to distinguish integer IDs from semvers, it feels to me like it would be less surprising for users and future us if we didn't try to infer extra meaning from the provided values.
Which, given that, I'm not sure if ids[] is the best name for the parameter, since ID feels like it more refers to versions.id than versions.num. Naming is hard, so I don't know what's better, but maybe num[] or versions[] might be clearer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to return specified versions by filtering with the
ids[]parameter.