Add a new clippy mode to crater to test lint regressions
#391
Conversation
ecstatic-morse
force-pushed
the
clippy-mode
branch
from
0681269 to
c207b79
Compare
ecstatic-morse
changed the title
clippy mode to crater to test crater regressionsclippy mode to crater to test lint regressions
There was a problem hiding this comment.
Everything except the mount flag change looks great! Thank you!
I'd prefer not to pass --security-opt=label:disable to Docker though (we're basically running untrusted code and every bit of extra security helps). An alternative is to store the toolchain name on the filesystem urlencoded with a custom encode set (like we do during report generation) that includes : in it.
This commit also adds a method, `Toolchain::install_rustup_component` to install a rustup componenet on the given toolchain.
The test runs crater in `clippy` mode and compares `stable` with `stable+rustflags=-Dclippy::all` so that a regression will appear when clippy would emit a warning on a crate. Also adds a new local crate which compiles succesfully but causes clippy to emit a warning.
ecstatic-morse
force-pushed
the
clippy-mode
branch
2 times, most recently
from
e859fb3 to
1d89103
Compare
ecstatic-morse
force-pushed
the
clippy-mode
branch
from
1d89103 to
3985d0c
Compare
|
I reverted the changes to There's some crossover here with Windows support, so I chose to escape all characters which are invalid as part of a Windows path, not just |
pietroalbini
changed the title
clippy mode to crater to test lint regressionsclippy mode to crater to test lint regressions
|
@bors r+ |
|
📌 Commit 3985d0c has been approved by |
Add a new `clippy` mode to crater to test lint regressions Resolves #388. This adds a new mode, `clippy`, to crater which runs clippy on crates (duh :). I had to add some new options to minicrater, as well as change the invocation of `docker create`. See the commit messages for more info. This is still a work in progress as I'd like to add some documentation for the feature, but should be enough for a meaningful review.
|
💔 Test failed - checks-travis |
|
💔 |
Add a new `clippy` mode to crater to test lint regressions Resolves #388. This adds a new mode, `clippy`, to crater which runs clippy on crates (duh :). I had to add some new options to minicrater, as well as change the invocation of `docker create`. See the commit messages for more info. This is still a work in progress as I'd like to add some documentation for the feature, but should be enough for a meaningful review.
|
WTF bors. @bors r- retry |
|
Whoops, I forgot to add the results of the |
|
Okay, should be good to go now. |
|
Thanks! @bors r+ |
|
📌 Commit 42174eb has been approved by |
Add a new `clippy` mode to crater to test lint regressions Resolves #388. This adds a new mode, `clippy`, to crater which runs clippy on crates (duh :). I had to add some new options to minicrater, as well as change the invocation of `docker create`. See the commit messages for more info. This is still a work in progress as I'd like to add some documentation for the feature, but should be enough for a meaningful review.
|
☀️ Test successful - checks-travis, status-appveyor |
Add documentation for new clippy mode Instructions for populating `rustflags` are included elsewhere in the docs, so this single line should suffice. This should have been included in #391 (whoops).
Resolves #388.
This adds a new mode,
clippy, to crater which runs clippy on crates (duh :).I had to add some new options to minicrater, as well as change the invocation of
docker create. See the commit messages for more info.This is still a work in progress as I'd like to add some documentation for the feature, but should be enough for a meaningful review.