Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the versions of primitive-types to 0.13 and rlp to 0.6 #305

Merged
merged 3 commits into from
Jan 18, 2025
Merged

Upgrade the versions of primitive-types to 0.13 and rlp to 0.6 #305

merged 3 commits into from
Jan 18, 2025

Conversation

0xbillw
Copy link

@0xbillw 0xbillw commented Jan 10, 2025

No description provided.

@boundless-forest boundless-forest mentioned this pull request Jan 13, 2025
Open
@0xbillw
Copy link
Author

0xbillw commented Jan 17, 2025

The reason the PR is blocked is that it cannot pass the tests, and this testing step relies on an archived repository evm-tests, which in turn depends on primitive-types-v0.12. There’s no solution now.
Help me :) @sorpaas

@0xbillw
Copy link
Author

0xbillw commented Jan 18, 2025

The reason for upgrading the primitive-types in the evm is that one of its downstream projects, frontier, depends on it. In order for Frontier to upgrade to the stable2412 version of the polkadot-sdk, it must upgrade primitive-types (the stable2409 version has a memory leak issue).
This issue polkadot-evm/frontier#1584 mentions this problem.

@0xbillw 0xbillw mentioned this pull request Jan 18, 2025
Open
@0xbillw 0xbillw force-pushed the upgrade_primitive-types branch from 1f52c11 to d91e5b3 Compare January 18, 2025 02:03
nazar-pc
nazar-pc reviewed Jan 18, 2025
View reviewed changes
Copy link

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koushiro do you have permissions to review and merge this one too?

Cargo.toml Outdated Show resolved Hide resolved
@koushiro
Copy link
Contributor

The jsontest CI (depends on evm-tests) is annoying, I think we can disable it temporarily and rewrite this part later. @0xbillw

related issue: #182

@koushiro
Copy link
Contributor

@koushiro do you have permissions to review and merge this one too?

Yeah, I have permission

koushiro
koushiro reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@koushiro
Copy link
Contributor

@0xbillw could you remove the jsontests job from CI workflow?

@koushiro koushiro merged commit 6d86fe2 into rust-ethereum:v0.x Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazar-pc nazar-pc nazar-pc left review comments

@koushiro koushiro koushiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xbillw @koushiro @nazar-pc