Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo doc constants generation #796

Merged
merged 1 commit into from
Jan 4, 2024
Merged

cargo doc constants generation #796

merged 1 commit into from
Jan 4, 2024

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jan 4, 2024

Before:
изображение

After:
изображение

cc @Emilgardis

@burrbull burrbull requested a review from a team as a code owner January 4, 2024 05:37
@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2024

/ci diff pr

1 similar comment
@burrbull
Copy link
Member Author

burrbull commented Jan 4, 2024

/ci diff pr

@Emilgardis
Copy link
Member

Why did the diff jobs get skipped?
image

/ci diff pr

@Emilgardis Emilgardis mentioned this pull request Jan 4, 2024
@Emilgardis
Copy link
Member

/ci diff pr

Copy link

github-actions bot commented Jan 4, 2024

Diff for comment

@Emilgardis
Copy link
Member

ugh, must've been something wrong with the runner

I like this change, however I feel like it's a shame rustdoc shows it this way. If it'd be possible to render it as 0x0u32 I'd like it even more

@Emilgardis Emilgardis enabled auto-merge January 4, 2024 12:30
@Emilgardis Emilgardis added this pull request to the merge queue Jan 4, 2024
Merged via the queue into master with commit 6b14520 Jan 4, 2024
46 checks passed
@Emilgardis Emilgardis deleted the Ux branch January 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants