Small change for RISCV compilation #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
requested changes
Jun 11, 2024
|
|
||
| // if unset, try the default and fail eventually | ||
| DEFAULT_RISCV_GNU_TOOLCHAIN.into() | ||
| }); |
There was a problem hiding this comment.
I don't think it's appropriate to force every RISCV compilation to use the GNU toolchains - are there not other toolchains?
| base_config | ||
| .compiler("clang") | ||
| .no_default_flags(true) | ||
| .flag(&format!("--sysroot={riscv_gnu_toolchain_path}/riscv32-unknown-elf")) |
There was a problem hiding this comment.
IIRC this is beyond our MSRV.
|
Agreed, I'd like a lot more details and a CI job that compiles with RISCV. If we currently can't compile with riscv and now we can, that's cool, and I'd be willing to compromise on MSRV or other forms of flexibility to get that. But from this PR I can't tell what's going on. |
|
Sorry I accidentally opened this PR against the upstream vs. my own fork. Will close and then re-open with more details later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.