Add default generic type to ArbitraryOrd
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PartialOrd` trait uses a default generic type for the right hand side of the comparison. This is useful for example to compare an object to a foreign type. For the same reasons we should provide a default generic type to `ArbitraryOrd`. Add generic type to `ArbitraryOrd` and default to `Self`. I believe this also makes the trait object safe.
tcharding
changed the title
ArbitraryOrd
|
Hey @apoelstra would you take a look at this one please and check that my understanding is correct (re the object safety thing). No rush. |
54 tasks
|
Yeah, this looks to me like it'll make the trait object-safe (though it's not really obvious to me that you want/need object-safety for As I mentioned elsewhere you can API-test whether a given trait is object-safe. |
|
TIL Please see #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PartialOrdtrait uses a default generic type for the right hand side of the comparison. This is useful for example to compare an object to a foreign type. For the same reasons we should provide a default generic type toArbitraryOrd.Add generic type to
ArbitraryOrdand default toSelf. This adds functionality without effecting current users in any way.I believe this also makes the trait object safe C-OBJECT
Done while checking off item in #16