types: Add std feature
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would like to be able to use `types` in a no-std environment. The `HashMap` type is only available in `std` builds. `BTreeMap` lives in the `alloc` crate - use it instead.
There is no reason we cannot support non-std users. Lets keep the alloc requirement though. Add `std` feature and enable it by default.
Currently we have a dependency on `bitcoin_internals` just for the `write_err` macro. Copy the macro here and remove the dependency. Make the macro and module private.
|
@apoelstra your local CI should be able to chew through this now mate. |
|
Mad! thanks man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masteris currently broken because the linter is warning because of astdfeature (which is coming from our usage ofinternals::write_err).We can fix this breakage after observing that calling macros from other crates is error prone. Lets copy the macro. On the way add a
stdfeature and stop usingHashMap.This also allows the removal of the
internalsdependency. Sexy PR right here.Close: #12