Test everything in the blockchain section for v17 and v18
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the docs on mining functions.
Put trait implementions in the same order as the trait declaration. Internal change only.
Lets just stick with panics in the `integration_test` "library".
Implement a test for `getmempoolentry` and improve the `NodeExt` trait along the way.
Not sure why this is breaking. I tried: 1. Using `HashMap` instead of `BTreeSet` 2. Using bitcoin-cli to verify the docs and returned values match 3. Asking chatGPT to convert the stuff returned in (2) to structs and confirming it used a map
The `gettxoutproof` method returns a plain old `String` so it should be omitted. Leave the method implemented on `Client` though and use it to test `verifytxoutproof`.
`node` is excluded from the workspace so it currently does not get formatted by `just fmt`. Modify the `justfile` so that the `node` directory gets formatted. Includes a trivial error message change to make the line shorter.
`node` is excluded from the worspace so `just` commands that use cargo don't hit it. As we did for the `just fmt` command make the `just lint` command lint the `node` crate also.
|
I'm just going to merge, this is test code only. Hack, push, merge - YOLO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration tests for all the remaining methods in
blockchainsection.Use the
verifytool to check the work.Leaves
getblockstatsuntested for v18. Something is wrong with docs it seems. We can come back to it after all the other versions are done.