Skip to content

Commit

Permalink
Reduce number of supported minor versions
Browse files Browse the repository at this point in the history
We support Core back to v0.17.1 and currently explicitly test all minor
versions back to v22 - this is probably an overkill and is only going to
increase as Core progresses. Instead lets just test all minor versions
of the last three releases and then the latest minor version for older
releases.

This has the benefit of reducing the number of CI jobs.
  • Loading branch information
tcharding committed Dec 6, 2024
1 parent e9f752e commit c8941ab
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 30 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ Run from `rust.yml` unless stated otherwise. Total 11 jobs.
9. `Docsrs`
10. `Format`

+1 job for each supported version of Core.
+15 jobs - 1 for each supported version of Core.


7 changes: 0 additions & 7 deletions .github/workflows/rust.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -203,16 +203,9 @@ jobs:
"26_1",
"26_0",
"25_2",
"25_1",
"25_0",
"24_2",
"24_1",
"24_0_1",
"23_2",
"23_1",
"23_0",
"22_1",
"22_0",
"0_21_2",
"0_20_2",
"0_19_1",
Expand Down
11 changes: 2 additions & 9 deletions integration_test/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,26 +12,19 @@ edition = "2021"
# - `cargo test --no-default-features` skips all tests.
[features]
# Enable the same feature in `node` and the version feature here.
# All minor releases (but only the latest patch release).
# All minor releases of the latest three versions.
28_0 = ["v28", "node/28_0"]
27_2 = ["v27", "node/27_2"]
27_1 = ["v27", "node/27_1"]
27_0 = ["v27", "node/27_0"]
26_2 = ["v26", "node/26_2"]
26_1 = ["v26", "node/26_1"]
26_0 = ["v26", "node/26_0"]
# Only the latest minor version for older versions.
25_2 = ["v25", "node/25_2"]
25_1 = ["v25", "node/25_1"]
25_0 = ["v25", "node/25_0"]
24_2 = ["v24", "node/24_2"]
24_1 = ["v24", "node/24_1"]
24_0_1 = ["v24", "node/24_0_1"]
23_2 = ["v23", "node/23_2"]
23_1 = ["v23", "node/23_1"]
23_0 = ["v23", "node/23_0"]
22_1 = ["v22", "node/22_1"]
22_0 = ["v22", "node/22_0"]
# Only the latest minor version for these.
0_21_2 = ["v21", "node/0_21_2"]
0_20_2 = ["v20", "node/0_20_2"]
0_19_1 = ["v19", "node/0_19_1"]
Expand Down
19 changes: 6 additions & 13 deletions node/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,26 +44,19 @@ default = ["28_0"]
# download is not supposed to be used directly only through selecting one of the version feature
download = ["bitcoin_hashes", "flate2", "tar", "minreq", "zip"]

# We support all minor releases (but only the latest patch release).
# We support all minor releases of the latest three versions.
28_0 = ["download", "27_2"]
27_2 = ["download", "27_1"]
27_1 = ["download", "27_0"]
27_0 = ["download", "26_2"]
26_2 = ["download", "26_1"]
26_1 = ["download", "26_0"]
26_0 = ["download", "25_2"]
25_2 = ["download", "25_1"]
25_1 = ["download", "25_0"]
25_0 = ["download", "24_2"]
24_2 = ["download", "24_1"]
24_1 = ["download", "24_0_1"]
24_0_1 = ["download", "23_2"]
23_2 = ["download", "23_1"]
23_1 = ["download", "23_0"]
23_0 = ["download", "22_1"]
22_1 = ["download", "22_0"]
22_0 = ["download", "0_21_2"]
# We only support the latest minor version for these.
# We only support the latest minor version for older versions.
25_2 = ["download", "24_2"]
24_2 = ["download", "23_2"]
23_2 = ["download", "22_1"]
22_1 = ["download", "0_21_2"]
0_21_2 = ["download", "0_20_2"]
0_20_2 = ["download", "0_19_1"]
0_19_1 = ["download", "0_18_1"]
Expand Down

0 comments on commit c8941ab

Please sign in to comment.