Skip to content

Commit

Permalink
Remove feature gating from test_p2p unit test
Browse files Browse the repository at this point in the history
This test works for `28_0`. It does not need feature gating out.

The reason this was done is because it cannot be run in parallel with
`test_multi_p2p`. We can leave that one feature guarded out in v28
builds.

The underlying issue is a problem with how Bitcoin Core binds to ports
and is tracked in #41
  • Loading branch information
tcharding committed Jan 22, 2025
1 parent 3a72c19 commit 52050fa
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions node/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,6 @@ mod test {
use tempfile::TempDir;

use super::*;
#[cfg(not(feature = "28_0"))]
use crate::P2P;
use crate::{exe_path, get_available_port, Conf, Node, LOCAL_IP};

Expand Down Expand Up @@ -628,9 +627,6 @@ mod test {
}

#[test]
// When this test is run at the same time as `test_multi_p2p` for v28 it fails.
// FIXME: Debug this failure - test runs ok on its own.
#[cfg(not(feature = "28_0"))]
fn test_p2p() {
let exe = init();

Expand Down Expand Up @@ -858,7 +854,6 @@ mod test {
assert!(node.params.zmq_pub_raw_block_socket.is_none());
}

#[cfg(not(feature = "28_0"))]
fn peers_connected(client: &Client) -> usize {
// FIXME: Once client implements get_peer_info use it.
// This is kinda cool, it shows we can call any RPC method using the client.
Expand Down

0 comments on commit 52050fa

Please sign in to comment.