Support file formatting and linting #38
Conversation
| @@ -1,8 +1,14 @@ | |||
| mod common; | |||
| use common::*; | |||
| use smir_pretty::{stable_mir_driver, print_all_items_verbose}; | |||
| use smir_pretty::{print_all_items_verbose, stable_mir_driver}; | |||
There was a problem hiding this comment.
I think this is actually dead code? Cannot find any print_all_items_verbose 🤔
There was a problem hiding this comment.
I will add an issue to go through and see if we can clean up old comments and unused imports!
.github/workflows/test.yml
Outdated
| run: | # Warning check should be redundant | ||
| RUSTFLAGS='--deny warnings' cargo build -vv |
There was a problem hiding this comment.
What does this comment mean? Maybe it would make more sense to put --deny warnings in the build step for code-quality?
There was a problem hiding this comment.
It is, I think that cargo clippy should catch every error the compiler would have.It is redundant, should I just remove it?
There was a problem hiding this comment.
This made me realise that the integration-tests job wasn't dependent on code-quality. I think we normally do that and so I have changed it
Yeah it is all formatting changes |
This PR will add code quality checks to CI through cargo clippy and cargo fmt
Closes #37