Allow partial function evaluation to be caught by bindings #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of the code here doesn't need to be written as hand-coded LLVM (bar one tailcc call), so we can push the implementation into C++ to make subsequent refactorings easier.
Baltoli
requested review from
theo25,
geo2a,
Scott-Guest,
goodlyrottenapple,
gtrepta and
dwightguth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the backend's ability to recover from errors when partial functions are evaluated in the context of a bindings library. Rather then unconditionally crashing the entire host process, we throw an exception that the bindings code can catch and translate to a C-ABI error structure for the backend to deal with.
Previously, we implemented this behaviour for hooks (#955); this PR does the same for general partial function evaluation. The changes are as follows:
finish_rewritingfrom LLVM IR into C++.llvm-kompileto pass this flag when compiling a bindings library.Fixes #925