Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gc refactor3 rebased #1195

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Gc refactor3 rebased #1195

merged 7 commits into from
Jan 22, 2025

Conversation

stevenmeker
Copy link
Collaborator

The condition for requesting collections is replaced by requesting a collection
if an allocation passes a tripwire. This tripwire is initially set at MIN_SPACE
and is recalculated after each garbage collation as max(MIN_SPACE, |live data|).

This avoids a potential issue with the old behavior where collections were
trigged by allocating in the last 1 MB of previously allocated semispace, even
if little garbage is being generated, or not collecting frequently enough if
a period of low garbage generation is followed by a period of high garbage
generation, affecting cache performance.

Furthermore, garbage collections are only trigged by allocations in youngspace.
Allocations in oldspace no longer trigger collections since oldspace collections
are handled during a youngspace collection.
Allocations in alwaysgcspace no longer trigger collections since collection
of this space is handled outside of the main garbage collector.

Some class arena member functions have the arena_ component removed as superfluous.

@rv-jenkins rv-jenkins changed the base branch from master to develop January 14, 2025 21:35
@dwightguth dwightguth merged commit c55f039 into develop Jan 22, 2025
10 checks passed
@dwightguth dwightguth deleted the gc_refactor3_rebased branch January 22, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants