Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No proof hint events for unit/elememt collection hooks #1150

Merged
merged 2 commits into from
Sep 23, 2024
Merged

No proof hint events for unit/elememt collection hooks #1150

merged 2 commits into from
Sep 23, 2024

Conversation

theo25
Copy link
Collaborator

@theo25 theo25 commented Sep 20, 2024

The unit/element hooks for collections are not useful to the math proof team so we modify our instrumentation to not emit them at all.

@rv-jenkins rv-jenkins changed the base branch from master to develop September 20, 2024 20:17
dwightguth
dwightguth approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Did you confirm that the events for simplifying the arguments of elements still get emitted?

Robertorosmaninho
Robertorosmaninho approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would like us to update the documentation just to be sure that this modification is highlighted there as a feature, not as as bug.

@theo25
Copy link
Collaborator Author

theo25 commented Sep 23, 2024

@dwightguth yes the events related to argument evaluation should be generated as always.

@rv-jenkins rv-jenkins merged commit c23fb6f into develop Sep 23, 2024
11 checks passed
@rv-jenkins rv-jenkins deleted the skip-unit-hooks branch September 23, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robertorosmaninho Robertorosmaninho Robertorosmaninho approved these changes

@dwightguth dwightguth dwightguth approved these changes

@gtrepta gtrepta Awaiting requested review from gtrepta

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theo25 @dwightguth @Robertorosmaninho @rv-jenkins