Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4844: Add Blob transaction type #2690

Merged
merged 17 commits into from
Jan 23, 2025

Conversation

Robertorosmaninho
Copy link
Collaborator

@Robertorosmaninho Robertorosmaninho commented Jan 21, 2025

This PR introduces a new type of EIP-2718 transaction type, the Blob transaction specified in the EIP-4844. This is the first from a series of PR needed to fully support the EIP.

This PR also extends:

  • The messages k-cell with 2 new cells: txMaxBlobFee (Int) and txVersionedHashes (JSONs). This last one may be just a temporary solution, as the BLOBHASH opcode needs a list where it can access the ith element.
  • the load/check transactions expressions to ensure the new transaction type is parsed as expected.

From the EIP specification: "The field `to` deviates slightly from the semantics with the exception that it *MUST NOT* be `nil` and therefore must always represent a 20-byte address. This means that blob transactions cannot have the form of a create transaction."
@Robertorosmaninho Robertorosmaninho marked this pull request as ready for review January 21, 2025 18:00
Implementing parsing features for `txVersionedHashes` and `txMaxBlobFee`
@Robertorosmaninho Robertorosmaninho changed the title EIP-4844: Add DynamicFee transaction type EIP-4844: Add BlobFee transaction type Jan 22, 2025
@Robertorosmaninho Robertorosmaninho changed the title EIP-4844: Add BlobFee transaction type EIP-4844: Add Blob transaction type Jan 22, 2025
Copy link
Collaborator

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but I'll let RV approve. Note my comment on the suggestion that was prematurely marked as resolved.

kevm-pyk/src/kevm_pyk/kproj/evm-semantics/evm-types.md Outdated Show resolved Hide resolved
Robertorosmaninho and others added 6 commits January 23, 2025 11:12
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
Co-authored-by: Andrei Văcaru <[email protected]>
@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 6cf81f6 into master Jan 23, 2025
12 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the pi2/robertorosmaninho/eip-4844 branch January 23, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants