Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create prop-hunt-2 #7579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

willrobaggins
Copy link

@willrobaggins willrobaggins commented Mar 4, 2025

Pulled Idyl's code from his PropHunt plugin, it is currently inactive due to him taking the server offline which was passing data.

I have opened a new server and edited the code to direct traffic there, effectively resurrecting the plugin.

The code has been tested and the server is speaking with the plugin.

@runelite-github-app
Copy link

runelite-github-app bot commented Mar 4, 2025

@cdfisher
Copy link
Contributor

cdfisher commented Mar 4, 2025

Don't open new PRs, just push changes to the existing branch if you need to make any. Additionally, we would prefer you follow the plugin takeover policy rather than duplicating the existing plugin, as felanbird mentioned on your previous PR.

Since you're largely taking the code from Idyl's plugin, he should also be listed in your license file.

@willrobaggins
Copy link
Author

Don't open new PRs, just push changes to the existing branch if you need to make any. Additionally, we would prefer you follow the plugin takeover policy rather than duplicating the existing plugin, as felanbird mentioned on your previous PR.

Since you're largely taking the code from Idyl's plugin, he should also be listed in your license file.

Understood. I updated the LICENSE (only as this issue was left open).

Additionally, I have opened an Issue as well as tried to contacct the author. From reviewing the takeover policy, I will give 7 days before proceeding.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants