Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trouble-brewing #7572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update trouble-brewing #7572

wants to merge 1 commit into from

Conversation

MaxPhilips
Copy link

@runelite-github-app
Copy link

Includes changes by non-author

trouble-brewing: 4d983508ad442aeb7ed4357f22ffd658ae853721...b226605aa1061f078a116bc79b5d8395bb778376

@MaxPhilips MaxPhilips mentioned this pull request Mar 3, 2025
Open
@pajlada
Copy link
Contributor

pajlada commented Mar 3, 2025

@Biffo89 Are you OK with this change being made to your plugin?

@MaxPhilips
Copy link
Author

this is the first time i'm trying to get a plugin published - is there a hard block for the original author's approval? it seems like they are no longer active given this comment: Biffo89/Trouble-Brewing#3 (comment) and that they haven't replied to other queries asking them to open this PR

they were the one who merged the only PR to their repo between 4d98350 and the new commit in this change, though i understand if that's not strong enough

is there anything else i could do as an outsider to help this change through?

@Nightfirecat
Copy link
Member

Please read the plugin hub takeover policy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
non-author plugin change plugin change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxPhilips @pajlada @Nightfirecat