Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create special-attack-infobox #7562

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Create special-attack-infobox #7562

wants to merge 3 commits into from

Conversation

iZupe
Copy link

@iZupe iZupe commented Mar 2, 2025

Adds an infobox that displays the current special attack energy

Adds an infobox that displays the current special attack energy
@runelite-github-app
Copy link

runelite-github-app bot commented Mar 2, 2025

@cdfisher
Copy link
Contributor

cdfisher commented Mar 2, 2025

Not a full review but this should remove the overlay on shutdown.

Additionally, it would probably be preferable to have an "always on" option added for the infobox created by the existing "Spec Overlay" plugin, so consider contributing to the existing plugin rather than submitting an entirely new one.

The overlay is now removed on shutdown
@iZupe
Copy link
Author

iZupe commented Mar 2, 2025

Not a full review but this should remove the overlay on shutdown.

Additionally, it would probably be preferable to have an "always on" option added for the infobox created by the existing "Spec Overlay" plugin, so consider contributing to the existing plugin rather than submitting an entirely new one.

I've updated the plugin to remove the overlay on shutdown. I created this plugin because the spec overlay plugin is for the soulreaper axe. This plugin can be used in all situations when the resizable inventory obstructs the special attack minimap orb and the current energy can't be seen.

@cdfisher
Copy link
Contributor

cdfisher commented Mar 2, 2025

Not a full review but this should remove the overlay on shutdown.
Additionally, it would probably be preferable to have an "always on" option added for the infobox created by the existing "Spec Overlay" plugin, so consider contributing to the existing plugin rather than submitting an entirely new one.

I've updated the plugin to remove the overlay on shutdown. I created this plugin because the spec overlay plugin is for when soulreaper axe. This plugin can be used in all situations when the resizable inventory obstructs the special attack minimap orb and the current energy can't be seen.

I understand what the Spec Overlay plugin currently does. I was suggesting that you could contribute to that plugin to add an option to always show the infobox, regardless of what the player's equipped items are.

@iZupe
Copy link
Author

iZupe commented Mar 2, 2025

Not a full review but this should remove the overlay on shutdown.
Additionally, it would probably be preferable to have an "always on" option added for the infobox created by the existing "Spec Overlay" plugin, so consider contributing to the existing plugin rather than submitting an entirely new one.

I've updated the plugin to remove the overlay on shutdown. I created this plugin because the spec overlay plugin is for when soulreaper axe. This plugin can be used in all situations when the resizable inventory obstructs the special attack minimap orb and the current energy can't be seen.

I understand what the Spec Overlay plugin currently does. I was suggesting that you could contribute to that plugin to add an option to always show the infobox, regardless of what the player's equipped items are.

I see. I do not know how to do that since my coding abilities are almost nonexistent.

@LlemonDuck
Copy link
Contributor

@LlemonDuck
Copy link
Contributor

Otherwise, you would go to https://github.com/OmbudRov/Spec-Overlay, clone it (or edit via github web ui), add a new config option to show regardless of weapon, and you'd add it to this if https://github.com/OmbudRov/Spec-Overlay/blob/master/src/main/java/com/specoverlay/SpecOverlayPlugin.java#L67

Then you just make a pull request to the Spec-Overlay repository in the github ui, and they would hopefully accept it and submit it as a change to us.

I can't imagine we need a third sra spec energy plugin.

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 3, 2025
@iZupe
Copy link
Author

iZupe commented Mar 3, 2025

Otherwise, you would go to https://github.com/OmbudRov/Spec-Overlay, clone it (or edit via github web ui), add a new config option to show regardless of weapon, and you'd add it to this if https://github.com/OmbudRov/Spec-Overlay/blob/master/src/main/java/com/specoverlay/SpecOverlayPlugin.java#L67

Then you just make a pull request to the Spec-Overlay repository in the github ui, and they would hopefully accept it and submit it as a change to us.

I can't imagine we need a third sra spec energy plugin.

I appreciate the help, but this isn't for the SRA spec. I play in resizable in the default game window size and the spec minimap orb is covered by the inventory. You cannot see the number for the current spec amount. I wanted an infobox that shows the current spec energy so I created one because it didn't exist on the plugin hub. I'm not a coder. I don't know what I'm doing and it's a miracle I got it to work after spending hours putting this together. I was thrilled to get this working and would greatly appreciate it if this was approved since I do not know how to change another plugin.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants