Update Dink to v1.11.2 #7561
Open
Update Dink to v1.11.2 #7561
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some concerns here, primarily around the by-default enablement and inclusion of screenshots. I'd prefer that it was opt-in since the URL is externally provided. Otherwise this introduces a non-obvious control flow which makes other plugins harder to review. Watchdog can be responsible for informing users that they will need to manually enable this behaviour in Dink's config. |
LlemonDuck
added
the
waiting for author
pajlada
removed
the
waiting for author
|
Updated to require user opt-in & force external plugins that specify a url to supply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dink v1.11.0 allows other plugins to trigger webhook notifications via
PluginMessagehttps://github.com/pajlads/DinkPlugin/releases/tag/v1.11.0
https://github.com/pajlads/DinkPlugin/releases/tag/v1.11.1
https://github.com/pajlads/DinkPlugin/releases/tag/v1.11.2