Bingo Plugin #7559
Open
Bingo Plugin #7559
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New plugin |
Added a notification for completion of the full board, Added a notification for completion of a row, Added more discord notifications for completions, More refactoring to the code has been done.
|
Don't sleep the shared executor service, it's a shared thread and you will starve other plugins. The screenshot system is already asynchronous and I'd recommend reworking your CompletableFuture to just resolve within requestNextFrameListener or better yet, just react asynchronously as well by queueing resultant handlers after the screenshot is taken. |
LlemonDuck
added
the
waiting for author
…hes improving performance in findAndMarkItem and loadSavedItems methods
Optimized Item Processing
Reduced redundant string comparisons and list iterations
Replaced stream operations with direct for-loop for better performance
Eliminated the need to create intermediate collections
Added proper clearing of the lookup map when resetting items
Improved checkForCompletions to only check diagonals when the item is actually on a diagonal
Reduced redundant calculations and boolean variables
Refactored more code
Fully Asynchronous Screenshot System (Replaced blocking CompletableFuture with a callback-based approach
Implemented proper asynchronous handling within the frame listener
Used scheduled tasks for retries instead of thread-blocking sleeps)
Better error handling and validation throughout
Simplified payload creation
Fixed issues with Discord webhook attachments
runelite-github-app
bot
removed
the
waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance your clan’s Bingo events with this plugin—designed to streamline tracking, scoring, and coordination of Bingo challenges within RuneLite. Perfect for hosting engaging, organized Bingo sessions for any clan or community.