Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IRC to v1.0 (008ef4d) #7474

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

ryanwohara
Copy link
Contributor

Complete refactor of the architecture.
More configuration options.
Multiple channel support.
Server selection.
Links are clickable.
Images can be previewed without your browser.
Font selector.
Best effort emoji support.
Ctrl+k, Ctrl+i, Ctrl+b, Ctrl+u support in the side panel.

Includes authors and new warning in the plugin metadata.

@runelite-github-app
Copy link

runelite-github-app bot commented Feb 19, 2025

@ryanwohara ryanwohara marked this pull request as draft February 19, 2025 06:47
@ryanwohara ryanwohara force-pushed the irc branch 6 times, most recently from 6c0b835 to d2adf04 Compare February 19, 2025 08:23
@ryanwohara ryanwohara changed the title IRC v1.0 Update IRC to v1.0 Feb 19, 2025
@ryanwohara ryanwohara changed the title Update IRC to v1.0 Update IRC to v1.0 (e12516c) Feb 19, 2025
@ryanwohara ryanwohara changed the title Update IRC to v1.0 (e12516c) Update IRC to v1.0 (da80a97) Feb 19, 2025
@ryanwohara ryanwohara changed the title Update IRC to v1.0 (da80a97) Update IRC to v1.0 (3a96374) Feb 19, 2025
@ryanwohara ryanwohara marked this pull request as ready for review February 19, 2025 17:37
@ryanwohara ryanwohara requested a review from a team as a code owner February 19, 2025 17:37
@ryanwohara
Copy link
Contributor Author

(This was discussed in Discord but I'm noting here for the sake of everyone)

I cannot find any instance of System.out calls in my codebase 🤔 this might be a false positive in the automated checks

@ryanwohara ryanwohara changed the title Update IRC to v1.0 (3a96374) Update IRC to v1.0 (e542b8d) Feb 19, 2025
@ryanwohara
Copy link
Contributor Author

Trying to remove the json dependency as it was duplicated and unnecessary for this work

@ryanwohara ryanwohara changed the title Update IRC to v1.0 (e542b8d) Update IRC to v1.0 (008ef4d) Feb 19, 2025
@ryanwohara
Copy link
Contributor Author

Downgrading kitteh irc seemed to have solved my issues - about to push up my changes.

@ryanwohara ryanwohara force-pushed the irc branch 2 times, most recently from 23d88ee to 3f6c213 Compare February 19, 2025 23:16
@ryanwohara ryanwohara requested a review from a team as a code owner February 19, 2025 23:16
@ryanwohara ryanwohara force-pushed the irc branch 2 times, most recently from 349f8e1 to 6c194c9 Compare February 19, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant