Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mlm-despawn-timer #7312

Merged
merged 3 commits into from
Feb 1, 2025
Merged

Conversation

xetrics
Copy link
Contributor

@xetrics xetrics commented Jan 30, 2025

A plugin to estimate/display when a vein will despawn in the Motherlode Mine.

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 30, 2025

@LlemonDuck
Copy link
Contributor

since you aren't currently using your config class you should remove (at least) the @Provides block in order to not show a settings icon beside your plugin in the config panel

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 30, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 30, 2025
@xetrics
Copy link
Contributor Author

xetrics commented Jan 30, 2025

I wasn't sure if the config implementation was needed for the plugin to function properly. I've removed it for now.

@iProdigy
Copy link
Member

iProdigy commented Feb 1, 2025

for completeness, could you remove from availableVeins upon the WallObjectDespawned event

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 1, 2025
@xetrics
Copy link
Contributor Author

xetrics commented Feb 1, 2025

I cannot, due to how MLM works. Veins are removed and readded on alternate ticks.

See: https://discord.com/channels/301497432909414422/419891709883973642/1334315881504702585

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 1, 2025
@iProdigy
Copy link
Member

iProdigy commented Feb 1, 2025

no worries, the availableVeins.clear() on LOADING gamestate (& this removal) should be sufficient (if not you can consider WeakHashMap & newSetFromMap)

@LlemonDuck LlemonDuck merged commit f9327d1 into runelite:master Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants