Ensure woodcutting animations repeat while chopping #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJacobHolden
commented
Jan 23, 2025
| if (!succeeds) { | ||
| this.actor.playAnimation(tool.animation); | ||
|
|
||
| // Keep chopping. | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think the line just below this findObject should be something like findItem to fix the bug where it says you receive a "large door" instead of "logs"
There was a problem hiding this comment.
You are correct, ill get that fixed
Promises
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random little bug I noticed while playing around.
Removed a strange tool level rule and redundant check (1 - infinity % 1 is always 0).
If anyone knows why you chop "large door" that'd be cool to fix too :P