Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add examples #17409

Closed
wants to merge 2 commits into from
Closed

feat: add examples #17409

wants to merge 2 commits into from

Conversation

VinciGit00
Copy link
Contributor

for ScrapegraphAI I added new integrations and fix an importe errror

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 2, 2025
@@ -13,7 +13,7 @@ pip install llama-index-tools-scrapegraph
First, import and initialize the ScrapegraphToolSpec:

```python
from llama_index.tools.scrapegraph import ScrapegraphToolSpec
from llama_index.tools.scrapegraph.base import ScrapegraphToolSpec
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, you shouldn't need.base -- in llama_index/tools/scrapegraph/__init__.py the tool spec should be exported there right? If not, lets export it there so that we can shorten the input

Copy link
Contributor Author

@VinciGit00 VinciGit00 Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where should I export it?

If I do not add the .base I have the following error:
Screenshot 2025-01-03 alle 09 31 10
Screenshot 2025-01-03 alle 09 32 50

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinciGit00 Looking at it, I think this is just an issue with your venv? I'm assuming probably because of how you installed from source?

In a fresh venv, I would

pip install -e  llama-index-core
pip install -e llama-index-integrations/tools/llama-index-tools-scrapegraph

from llama_index.tools.scrapegraph import ScrapegraphToolSpec works fine for me locally

It looks like a new version hasn't been published yet though, so I guess if you install from pypi, it won't have the fixed imports. Publishing a new version here
#17418

@logan-markewich logan-markewich self-assigned this Jan 2, 2025
@VinciGit00 VinciGit00 closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants